Fix broken multi-GPU path in run_solver#67
Open
sanjanag wants to merge 2 commits intolinkedin:masterfrom
Open
Conversation
The compute_device_num > 1 branch passed kwargs that don't match MatchingSolverDualObjectiveFunctionDistributed's signature, so any multi-GPU run_solver call raised TypeError immediately. Multi-GPU / multi-node usage requires a per-rank construction pattern that doesn't fit run_solver's single-process inputs. Raise NotImplementedError pointing to tests/distributed/test_matching_distributed.py. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the mlflow context wrapper and the dead invert_jacobi_precondition block from run_solver. Forward objective_kwargs to the matching objective so callers can configure it via ObjectiveArgs the same way the benchmark script does. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The multi-GPU code path in
run_solverwas non-functional and wouldfail at runtime. Multi-GPU / multi-node usage doesn't fit
run_solver's single-process API and requires a per-rank constructionpattern. Replace the broken dispatch with a clear
NotImplementedErrorso users hit a useful message instead of an internal
TypeError, andpoint them to the working pattern in the distributed tests.
Test plan
pytest tests/ --ignore=tests/distributed)NotImplementedErrorwith guidance